[FrameworkBundle] Make the Router cache_dir configurable
#47496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot.io failure is not due to this PR |
|
(Rebased needed) |
|
Merge conflicts resolved. |
fabpot
approved these changes
Oct 1, 2022
|
@mpdude Can you rebase to get rid of the merge commit? |
e7cace1 to
5804c50
Compare
|
@fabpot done |
|
Out of curiosity, (why) would a merge commit matter if you do a squash merge anyway? |
5804c50 to
dd65d30
Compare
|
The script we are using to do the merge doesn't always work well in such situations. |
|
Thank you @mpdude. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 1, 2022
…ude) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- Document the `framework.router.cache_dir` setting This documents a new configuration setting suggested in symfony/symfony#47496. Commits ------- 24b9b1d Document the `framework.router.cache_dir` setting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
framework.router.cache_dirconfiguration setting. It will default tokernel.cache_diras previously, but makes it possible to easily re-configure the Router's cache directory.My intended use case is to set it to
~(null) for thetestenvironment because I need to modify or otherwise dynamically load routes during tests. Another use case I see for it is to have tenant-specific route configurations and caches in multi-tenancy applications.