[Messenger] [AMQP] Support “content encoding” property #47545
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -18,6 +18,7 @@ | |||
| "require": { | |||
| "php": ">=8.1", | |||
| "ext-amqp": "*", | |||
| "ext-zlib": "*", | |||
There was a problem hiding this comment.
As this is optional, it should be moved to require-dev instead.
src/Symfony/Component/Messenger/Bridge/Amqp/Transport/AmqpReceiver.php
Outdated
Show resolved
Hide resolved
|
|
||
| class Gzip implements CompressorInterface | ||
| { | ||
|
|
src/Symfony/Component/Messenger/Bridge/Amqp/Compressor/CompressorFactory.php
Outdated
Show resolved
Hide resolved
|
You should also rebase to get rid of the merge commit. |
When I send a message using the AMQP transport together with the AmqpStamp and the content-encoding property, the message is not compressed.
The AMQP protocol, allow through the content-encoding property, to “indicate what additional content encodings have been applied to the application-data, and thus what decoding mechanisms need to be applied in order to obtain the media-type referenced by the content-type header field”.
The values admitted according to the protocol are: gzip, compress, deflate, identity, etc.
I expect that the body of the message will be compressed and decompressed respectively by the publisher
and the subscriber.
For example, we can send a messages:
and, With the current code the body message (payload) is not compress using gzip:
$ rabbitmqadmin get queue=messages -f pretty_json [ { "exchange": "messages", "message_count": 0, "payload": "{\"name\":\"Foo bar\"}", "payload_bytes": 18, "payload_encoding": "string", "properties": { "content_encoding": "gzip", "content_type": "application/json", "delivery_mode": 2, "headers": { "X-Message-Stamp-Symfony\\Component\\Messenger\\Stamp\\BusNameStamp": "[{\"busName\":\"messenger.bus.default\"}]", "type": "App\\Message\\DummyMessage" }, "timestamp": 1662922329 }, "redelivered": true, "routing_key": "" } ]but, if we are aware of the value of the content_encoding property we should compress the body message.
$ rabbitmqadmin get queue=messages -f pretty_json [ { "exchange": "messages", "message_count": 0, "payload": "H4sIAAAAAAAAA6tWysxNTE8NyC8u8UxRsrI0qwUAri6HchIAAAA=", "payload_bytes": 38, "payload_encoding": "base64", "properties": { "content_encoding": "gzip", "content_type": "application/json", "delivery_mode": 2, "headers": { "X-Message-Stamp-App\\Messenger\\UniqueIdStamp": "[{\"uniqueId\":\"631e4bdc3ad3b\"}]", "X-Message-Stamp-Symfony\\Component\\Messenger\\Stamp\\BusNameStamp": "[{\"busName\":\"messenger.bus.default\"}]", "type": "App\\Message\\AddPonkaToImage" }, "timestamp": 1662929884 }, "redelivered": true, "routing_key": "" } ]Finally, the subscriber must be able to uncompressed the body message. I made some changes in order to figure out how
this can be accomplished.
Thanks!, I should be grateful for any comments.