[Cache] Allow colon (:) in cache key #47561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Sep 13, 2022
| Q | A |
|---|---|
| Branch? | 6.2 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #45599 |
| License | MIT |
| Doc PR |
|
I guess I must edit a CHANGELOG.md but I don't understand how it work. Is it |
|
Tests fail, we need to override some methods from the base class. |
|
Should we do this only when the contracts are used? Aka when using the PSR-6 interface, still throw? |
|
I've described why it would be better to still forbid semicolons in cache keys in the #45599. |
|
I'm closing here because this was a poc and it showed we need more discussion - also because the implementation is likely not the one we'll want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.