[Messenger] Separate WorkerRunningEvent into WorkerBusyEvent and WorkerIdleEvent #47573
+105
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common usecase for WorkerRunning listeners seems to be that they perform logic based on
$event->isWorkerIdle()
. E.g. sometimes services only need to reset if a message has been processed. Or non-critical logic needs to happen when the worker is not busy, to keep the processing performant (like keeping a cache warm or sending buffered metrics).Right now each of those listeners need to be called, upon which they check themselves if the worker is busy. To increase performance, the WorkerRunning event can be split into
WorkerBusyEvent
andWorkerIdleEvent
. This way listeners can be explicit about when they want to act. Since these events are emitted in a loop, this could make a difference.There doesn't seem to be a way to deprecate an event, so I think the
WorkerRunning
event remains.Though
WorkerRunning::isWorkerIdle()
could be deprecated to stimulate the usage of the new events.