Skip to content

Add warning for possibly truncated inputs in SecretsSetCommand (#47586) #47587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add warning for possibly truncated inputs in SecretsSetCommand (#47586) #47587

wants to merge 2 commits into from

Conversation

pbek
Copy link
Contributor

@pbek pbek commented Sep 15, 2022 •
edited
Loading

Q A
Branch? 6.2 for features / 4.4, 5.4, 6.0 or 6.1 for bug fixes
Bug fix? yes
Tickets Fix #47586
License MIT

Adds a warning for possibly truncated inputs in SecretsSetCommand.

@carsonbot carsonbot added this to the 6.2 milestone Sep 15, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@pbek pbek mentioned this pull request Sep 15, 2022
Closed
@pbek pbek changed the title Add warning for possibly truncated inputs (#47586) Add warning for possibly truncated inputs in SecretsSetCommand (#47586) Sep 15, 2022
@pbek @fabpot
Update warning text (symfony#47586)
9c322d3 
Co-authored-by: Fabien Potencier <fabien@potencier.org>
@pbek
Copy link
Contributor Author

pbek commented Sep 21, 2022

Just a note: If #47588 would get accepted, this PR is redundant and can be ignored.

@fabpot
Copy link
Member

fabpot commented Sep 23, 2022

Closing in favor of #47588

@fabpot fabpot closed this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

Assignees
No one assigned
Labels
Bug Status: Needs Work
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

QuestionHelper input truncated at 4095 byte
3 participants
@pbek @carsonbot @fabpot