-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Update the mailer panel #47643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One thing that seems gone is showing which transport was used for each email (previously, it was shown in the tabs switching between emails) |
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Outdated
Show resolved
Hide resolved
@javiereguiluz can you share the before/after comparison for how the panel looks like with multiple transports ? |
@stof thanks for the review. About the transport, to reduce the noise I thought it was a good idea to only display the transport if there's more than one transport. This is how it'd look like when showing the transport name: But thanks to your comment, I realized that maybe your app defines multiple transports, but this request only used one of them ... so you need the transport info somewhere. What about showing it like this: Do you know how long can be the transport name in practice? It's the full DNS or a human-friendly short name? Thanks! |
IIRC, it is the full DSN (minus the auth part) |
what about showing multiple emails inbox-like? eg. a list of subject and date. |
@ro0NL I doubt you will have web requests sending lots of emails (such case must be handled asynchronously). So it is better to optimize the experience for a few emails than for the case of a big list IMO. |
im not sure how not seeing the subject improves the experience ... |
Well, if you want to display the subject instead of just |
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Outdated
Show resolved
Hide resolved
I liked @ro0NL proposal, so I gave it a shot ... and I think it works better. It now shows a clickable list of messages to follow the familiar behavior of email clients: We also protect the design against too long lists: |
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Show resolved
Hide resolved
@stof I thought about what you said and I think you were right. That's why I've changed my mind and introduced some buttons in the table of emails to make it accessible. This is how it looks when using a browser with accessibility capabilities. In regular browsers, the buttons are completely hidden: So, I think this feature is now ready and complete. Thanks. |
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Show resolved
Hide resolved
Thank you @javiereguiluz. |
Related to #47148, this updates one of the panels which weren't updated in that other PR.
Before - 1 email sent
Before - Multiple emails sent
Before - Email attachments
After - 1 email sent
Comments:
After - Multiple emails sent
Comments:
After - MIME parts
Comments:
After - Raw message
Comments:
*.eml
file