Skip to content

Add a few more ??= #47649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add a few more ??= #47649

merged 1 commit into from
Sep 23, 2022

Conversation

tigitz
Copy link
Contributor

@tigitz tigitz commented Sep 21, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Continuation of #47549 using rector with this config

<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Php74\Rector\Assign\NullCoalescingOperatorRector;

return static function (RectorConfig $rectorConfig): void {
   $rectorConfig->rule(NullCoalescingOperatorRector::class);
};

@carsonbot carsonbot added this to the 6.2 milestone Sep 21, 2022
@tigitz
Copy link
Contributor Author

tigitz commented Sep 21, 2022

friendly ping @nicolas-grekas as it's a continuation of your work

nicolas-grekas
nicolas-grekas approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor thing

@tigitz tigitz mentioned this pull request Sep 21, 2022
Closed
7 tasks
@tigitz
Copy link
Contributor Author

tigitz commented Sep 21, 2022

@nicolas-grekas Done 👌

Thanks everyone for the review.

@fabpot
Copy link
Member

fabpot commented Sep 23, 2022

Thank you @tigitz.

@fabpot fabpot merged commit 9258cb5 into symfony:6.2 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@yceruto yceruto yceruto approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
8 participants
@tigitz @fabpot @nicolas-grekas @stof @OskarStark @derrabus @yceruto @carsonbot