[WebProfilerBundle] [WebProfilerPanel] Update the configuration panel #47665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 22, 2022
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/config.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/config.html.twig
Outdated
Show resolved
Hide resolved
|
@stof thanks for your review. I've fixed everything. |
stof
reviewed
Sep 22, 2022
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/config.html.twig
Outdated
Show resolved
Hide resolved
stof
approved these changes
Sep 22, 2022
|
@javiereguiluz I see that the CSS contains lots of panel-specific styles in this redesign. Should some of them become reusable components instead (in a separate PR), that third-party bundles could use as well in their own panels, or are they really ultra specific to those panels ? |
|
In these last cases I think the design is very specific to those features, so it's not really reusable. |
fabpot
approved these changes
Sep 23, 2022
6fdb73a to
48ec448
Compare
|
Thank you @javiereguiluz. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to update the "Symfony status" information in the "Config" panel of the Symfony Profiler. Today it's displayed as a table:
I'd prefer to display that information more visually:
The wording has been updated a bit too ("In development" vs "Unstable version") to better match the wording used at https://symfony.com/releases/6.2
Here's the case of a LTS version:
And for an unmaintained version: