Thank you @X-Coder264.

@X-Coder264 Our automated tests detected this one also. You found the root cause faster than I did. Thank you.

Heh just ran into this one today when upgrading from 4.4.45 to 4.4.46; added a conflict rule for now to our composer.json - cheers for the quick fix!

Same problem here with an upgrade from 5.4.11 to 5.4.13

With this simple controller which should return a PNG :

 /** @Route("/yolo") */
    public function yolo()
    {
        return new BinaryFileResponse('/www/var/storage/test/yolo.png');
    }

I get this :

The content-type of the picture is text/html; charset=UTF-8

It works OK when the picture is in a html page (the browser is fixing the faulty content-type on the fly) but my functional tests do not pass.

If I force the content-type with a return new BinaryFileResponse('/www/var/storage/test/yolo.png', 200, ['content-type' => 'image/png']); it works.

Will this fix be released in 5.4.14 ?

Will this fix be released in 5.4.14 ?

yes

@Trismegiste i had the same problem quick fix manual add mime type

/** @Route("/yolo") */
public function yolo()
{
    $response = new BinaryFileResponse('/www/var/storage/test/yolo.png');

    $mimeTypes = new MimeTypes();
    $mimeType = $mimeTypes->guessMimeType('/www/var/storage/test/yolo.png');
    $response->headers->set('Content-Type', $mimeType);

    return $response;
}

yes

Thank you @xabbuh

@Trismegiste i had the same problem quick fix manual add mime type

Thank you @gimler but I think I'll keep 5.4.11 and upgrade later

Thank you @gimler but I think I'll keep 5.4.11 and upgrade later

… or use "symfony/http-foundation": "~5.4.14@dev" as version constraint for the time being. This way you can verify that the upcoming release will address your issue.

When will this be released?

Patch releases happen once per month.

Is there an exception to that? This is not some rare/small/obscure issue, this is a pretty big issue with a lot of impact as almost every project uses the BinaryFileResponse which can be seen by the amount of bug reports that are constantly being opened all over the place (here, on Symfony community bundles, on the Laravel framework repo etc.).

Honestly I was a bit surprised that a new patch version was not released immediately after the fix was merged.

releases for all maintained versions containing this fixed have just been released

Tested right now.
5.4.14 release fixed my problem with BinaryFileResponse
Thanks ❤️