-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] fixed traceable decoration priorities #47764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] fixed traceable decoration priorities #47764
Conversation
96fc2dc
to
c8c096d
Compare
c8c096d
to
4857205
Compare
This makes sense to me. |
Hmm, re-reading this, would make sense to make the traceable decorator last indeed… but since we don't have any unexpected report for this yet, perhaps keep this status-quo for the validator one. 🤷🏻♂️ |
Indeed, I think that decorating a validator isn't a common use case (I think almost nobody tried it). |
I agree, let's keep it as-is as long as nobody actually complains (from my experience that kind of bugfixes in old versions is source of problems/anger -_-) |
Thank you @mtarld. |
Related to symfony/maker-bundle#1252
The decoration priority of
TraceableNormalizer
andTraceableEncoder
is too high, therefore while it should be the last decoration applied, it is applied before userland decorations.I've set the decoration priority to
0
, but maybe-255
might be better.Moreover, I've seen the very same thing for the
TraceableValidator
, is it a bug or wanted?