[Console] Fix Helper::removeDecoration hyperlink bug
#47779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot.io tells me that there are two code style fixes somewhere else than in the code, I've added. Should I fix these as well or just leave them? |
fabpot
approved these changes
Oct 4, 2022
|
Thank you @greew. |
|
@fabpot The bug is also present in 5.x and 6.x - do you merge the bug up to these branches yourself or should I create PRs for those as well? |
Nevermind - I found the answer myself :) |
This was referenced Oct 12, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper::removeDecoration()does correctly remove colors and such from the text, but terminal hyperlinks are not removed here. This causesHelper::width()andHelper::length()to report wrong values, as the number of visual characters it not the same as the number of characters in the text.This PR
removeDecorationmethodTableTestto ensure that widths are correctly calculated for hyperlink texts (see [Console] URL in table does not align pipe if it spans more than one line #47769 for issue)See https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda for information about hyperlinks in terminals