Skip to content

[TwigBridge] Remove empty spaces between choices when using checkbox-inline or checkbox-switch #47833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

simondaigre
Copy link
Contributor

@simondaigre simondaigre commented Oct 11, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

This PR fixes empty spaces between choices when using checkbox-inline or checkbox-switch.

Remove empty spaces between choices.
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@simondaigre simondaigre changed the title Update bootstrap_5_layout.html.twig [TwigBridge] Remove empty spaces between choices when using checkbox-inline or checkbox-switch. Oct 11, 2022
@carsonbot carsonbot changed the title [TwigBridge] Remove empty spaces between choices when using checkbox-inline or checkbox-switch. Remove empty spaces between choices when using checkbox-inline or checkbox-switch. Oct 11, 2022
@carsonbot carsonbot changed the title Remove empty spaces between choices when using checkbox-inline or checkbox-switch. [TwigBridge] Remove empty spaces between choices when using checkbox-inline or checkbox-switch. Oct 11, 2022
@nicolas-grekas nicolas-grekas changed the title [TwigBridge] Remove empty spaces between choices when using checkbox-inline or checkbox-switch. [TwigBridge] Remove empty spaces between choices when using checkbox-inline or checkbox-switch Oct 11, 2022
@nicolas-grekas
Copy link
Member

Good catch, thanks @simondaigre.

@nicolas-grekas nicolas-grekas merged commit 57abeb8 into symfony:5.4 Oct 11, 2022
This was referenced Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants