Skip to content

[HttpClient] Don't override header if is x-www-form-urlencoded #47854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

[HttpClient] Don't override header if is x-www-form-urlencoded #47854

merged 1 commit into from
Oct 17, 2022

Conversation

Oipnet
Copy link
Contributor

@Oipnet Oipnet commented Oct 13, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47852
License MIT

When body is array and the Content-Type is application/x-www-form-urlencoded we not override the header

@carsonbot carsonbot added this to the 6.2 milestone Oct 13, 2022
@carsonbot carsonbot changed the title Don't override header if is x-www-form-urlencoded [HttpClient] Don't override header if is x-www-form-urlencoded Oct 13, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.1 Oct 17, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 6.1 October 17, 2022 17:17
@nicolas-grekas
Copy link
Member

Thank you @Oipnet.

@nicolas-grekas nicolas-grekas merged commit b191e69 into symfony:6.1 Oct 17, 2022
@nicolas-grekas
Copy link
Member

Amended in 4ed4367, my bad.

@fabpot fabpot mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@lyrixx lyrixx Awaiting requested review from lyrixx

@dunglas dunglas Awaiting requested review from dunglas

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[HttpClient] Content-Type header overridden if body is an array
4 participants
@Oipnet @nicolas-grekas @xabbuh @carsonbot