[Config][Routing] Nicer config syntax for PSR-4 route loading #47943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derrabus thanks for taking the time to update the config syntax of this feature 🙏 |
6ae58f7 to
94f0b72
Compare
stof
reviewed
Oct 21, 2022
src/Symfony/Component/Routing/Loader/schema/routing/routing-1.0.xsd
Outdated
Show resolved
Hide resolved
5328cf2 to
82b3b74
Compare
82b3b74 to
d7df3be
Compare
fabpot
approved these changes
Oct 22, 2022
|
Thank you @derrabus. |
|
symfony/recipes#1138 for the recipe update. |
fabpot
reviewed
Oct 22, 2022
| @@ -136,7 +136,11 @@ private function doImport(mixed $resource, string $type = null, bool $ignoreErro | |||
| try { | |||
| $loader = $this->resolve($resource, $type); | |||
|
|
|||
| if ($loader instanceof self && null !== $this->currentDir) { | |||
| if (!$loader instanceof self) { | |||
| return $loader->load($resource, $type); | |||
There was a problem hiding this comment.
@derrabus That does not work as the PSR-4 loader uses the locator but without the current dir, so the resource cannot be found. Or am I missing something?
fabpot
added a commit
that referenced
this pull request
Oct 23, 2022
…irectory (derrabus) This PR was merged into the 6.2 branch. Discussion ---------- [Config][Routing] Fix delegating to PSR-4 loader from subdirectory | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #47943 (comment) | License | MIT | Doc PR | N/A Commits ------- c1f0ccb Fix delegating to PSR-4 loader from subdirectory
Merged
fabpot
added a commit
that referenced
this pull request
Oct 27, 2022
…iles (derrabus) This PR was merged into the 6.2 branch. Discussion ---------- [Routing] Add tests for loading PSR-4 classes from PHP files | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follow-up to #47916, #47943 This PR adds more tests, demonstrating how to trigger the new PSR-4 loader from a PHP config file. Commits ------- 416639c Add tests for loading PSR-4 classes from PHP files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an alternative syntax for the PSR-4 route loader introduced in #47916.