[Notifier] Add support for editing Telegram messages #47956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Oct 23, 2022
| @@ -98,7 +100,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| if (200 !== $statusCode) { | |||
| $result = $response->toArray(false); | |||
|
|
|||
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code %s).', $result['error_code']), $response); | |||
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code "%s").', $result['error_code']), $response); | |||
There was a problem hiding this comment.
Maybe use post and edit accordingly?
fabpot
reviewed
Oct 23, 2022
| @@ -98,7 +100,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| if (200 !== $statusCode) { | |||
| $result = $response->toArray(false); | |||
|
|
|||
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code %s).', $result['error_code']), $response); | |||
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code "%s").', $result['error_code']), $response); | |||
There was a problem hiding this comment.
Suggested change
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code "%s").', $result['error_code']), $response); | |
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code %d).', $result['error_code']), $response); |
fabpot
reviewed
Oct 23, 2022
| @@ -98,7 +100,8 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| if (200 !== $statusCode) { | |||
| $result = $response->toArray(false); | |||
|
|
|||
| throw new TransportException('Unable to post the Telegram message: '.$result['description'].sprintf(' (code %s).', $result['error_code']), $response); | |||
| $verb = isset($options['message_id']) ? 'edit' : 'post'; | |||
fabpot
approved these changes
Oct 23, 2022
|
Thank you @chr-hertel. |
|
Really fast, thanks a lot! :) |
|
As always 🤷🏼♂️ 😁 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telegram supports updating messages which is quite a use case while working with buttons to create an interactive inline interface.
See https://core.telegram.org/bots/api#editmessagetext