-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Fix dealing with ext-redis' multi/exec returning a bool #47979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dealing with ext-redis' multi/exec returning a bool #47979
Conversation
Could you please add a testcase to avoid further regressions? Thanks |
Hey @OskarStark, now I'm puzzled. This was triggering an error (failure to set the key/value with TTL) and I was able to set a breakpoint (on my project) and observe the Was trying to reproduce it using a test but it seems to be working fine, so I'm unsure about the conditions that trigger the The documentation does seem to hint that I was able to verify that even if the cache set fails (due to this issue), the value is correctly written to Redis. For further context, I'm running this on a long-lived PHP process and the issue only seems to manifest itself on subsequent requests, but not on the first one. I've run tests using phpredis 5.3.7 as well as 5.3.4 (the one used on symfony's integration tests) and the results are the same. Switching to |
c729ba4
to
813f241
Compare
813f241
to
4d2b176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a try. Please report back if you see any unexpected behavior after this change.
Thank you @joaopbnogueira. |
When using
phpredis
client, the execution ofmulti/exec
might return a boolean instead of an array, leading to an error when yielding the result.