Skip to content

[ErrorHandler] s/</br>/<br> #48005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

[ErrorHandler] s/</br>/<br> #48005

merged 1 commit into from
Oct 27, 2022

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Oct 26, 2022 •
edited by derrabus
Loading

Q A
Branch? 5.4
Bug fix? no just a typo
New feature? no
Deprecations? no
License MIT

replace typo </br> with <br>

@PhilETaylor PhilETaylor requested a review from yceruto as a code owner October 26, 2022 20:09
@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1, 6.2.

Cheers!

Carsonbot

@PhilETaylor PhilETaylor changed the base branch from 5.3 to 5.4 October 26, 2022 20:10
@PhilETaylor PhilETaylor changed the title [ErrorReporter] s/</br>/<br> [ErrorHandler] s/</br>/<br> Oct 26, 2022
@derrabus derrabus added this to the 5.4 milestone Oct 26, 2022
@carsonbot carsonbot changed the title [ErrorHandler] s/</br>/<br> s/</br>/<br> Oct 26, 2022
@carsonbot carsonbot changed the title s/</br>/<br> [ErrorHandler] s/</br>/<br> Oct 26, 2022
@derrabus derrabus added the Bug label Oct 26, 2022
@fabpot
Copy link
Member

fabpot commented Oct 27, 2022

Good catch, thanks @PhilETaylor.

@fabpot fabpot merged commit a18aad8 into symfony:5.4 Oct 27, 2022
This was referenced Oct 28, 2022
Merged
Merged
Merged
@PhilETaylor PhilETaylor deleted the patch-5 branch October 28, 2022 18:07
@fabpot fabpot mentioned this pull request Oct 28, 2022
Merged
@ninsuo
Copy link

ninsuo commented Nov 29, 2022

This issue may be renamed to prevent breaking the changelog files 😄

PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@fabpot
bug symfony#48005 [ErrorHandler] s/</br>/<br> (PhilETaylor)
539cf14 
This PR was merged into the 5.4 branch.

Discussion
----------

[ErrorHandler] s/</br>/<br>

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no just a typo
| New feature?  | no
| Deprecations? | no
| License       | MIT

replace typo `</br>` with `<br>`

Commits
-------

7c8bcd8 s/<\br>/<br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug ErrorHandler Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@PhilETaylor @carsonbot @fabpot @ninsuo @derrabus @xabbuh