[DependencyInjection] Don't autoconfigure tag when it's already set with attributes #48027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 28, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #48019 |
| License | MIT |
| Doc PR | - |
|
Hey! I think @deguif has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Tobion
approved these changes
Oct 29, 2022
|
Thank you @nicolas-grekas. |
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Dec 5, 2022
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2022
…re tag when it's already set with attributes" (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Revert "bug #48027 Don't autoconfigure tag when it's already set with attributes" | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | | Tickets | Fix #48388 | License | MIT | Doc PR | - Reverting #48027, which is a regression. Commits ------- bd2780a Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus
added a commit
that referenced
this pull request
Dec 6, 2022
* 5.4: Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus
added a commit
that referenced
this pull request
Dec 6, 2022
* 6.0: Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus
added a commit
that referenced
this pull request
Dec 6, 2022
* 6.1: Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)"
derrabus
added a commit
that referenced
this pull request
Dec 6, 2022
* 6.2: Bump Symfony version to 6.2.2 Update VERSION for 6.2.1 Update CHANGELOG for 6.2.1 [DependencyInjection] Fix `ContainerBuilder` stats env usage with enum [Mailer] Fix rendered templates for notifications [HttpKernel] Fix using entities with the #[Cache()] attribute [DependencyInjection] Remove refs that point to container.excluded services when allowed Revert "bug #48027 [DependencyInjection] Don't autoconfigure tag when it's already set with attributes (nicolas-grekas)" [WebProfilerBundle] Use same color as other icons for the close toolbar btn [Profiler] Fix the dump view panel
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.