[HttpFoundation] Compare cookie with null value as empty string in ResponseCookieValueSame #48112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponseCookieValueSame
stof
approved these changes
Nov 4, 2022
|
Good decision. Thank you. |
maxbeckers
approved these changes
Nov 5, 2022
|
Thank you @fancyweb. |
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already consider
nullas''when we "compute" the cookie:symfony/src/Symfony/Component/HttpFoundation/Cookie.php
Line 253 in 4d4c411
So in the related issue,
self::assertResponseCookieValueSame('SOME_COOKIE_NAME', '');could be used. WDYT @werwolf666?