[VarExporter] Use array<property-name,Closure> for partial initialization of lazy ghost objects
#48209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of lazy ghost objects
66cecba to
efd6966
Compare
stof
reviewed
Nov 14, 2022
| @@ -36,37 +37,34 @@ class LazyObjectState | |||
| */ | |||
| public int $status = 0; | |||
|
|
|||
| public function __construct(public \Closure $initializer, $skippedProperties = []) | |||
| public function __construct(public readonly \Closure|array $initializer, $skippedProperties = []) | |||
There was a problem hiding this comment.
the structure of the array should be documented in phpdoc.
There was a problem hiding this comment.
This is an internal API, the phpdoc is on the public one.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy ghost objects can be either fully-initialized or partially-initialized: either the lazy-properties are all initialized at once, or they're initialized one-by-one.
In the one-by-one way, the initializer is still one closure for all properties that accepts the property to initialize as argument.
While preparing my talk for SymfonyCon, I realized that it would be better to pass an array of closures instead, keyed by the properties to lazy-initialize.