[PropertyInfo] ensure docblock compatibility with PhpStan's docblock parser #48215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In their next releases both packages phpdocumentor/reflection-docblock and phpdocumentor/type-resolver will start using the docblock parser from PhpStan.
|
The alternative solution would be to conflict with the upcoming minor releases of both package or see if phpDocumentor/ReflectionDocBlock#343 (comment) can be fixed over there instead. |
stof
approved these changes
Nov 15, 2022
|
Fixing that makes sense to me as it is only a test fixture anyway. However, I think phpDocumentor should still fix this before release their new version (or make it a new major version if they break some supported types) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In their next releases both packages phpdocumentor/reflection-docblock and phpdocumentor/type-resolver will start using the docblock parser from PhpStan.