[Notifier] [SMSBiuras] true/false mismatch for test_mode option
#48262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Nov 20, 2022
| @@ -85,7 +85,7 @@ protected function doSend(MessageInterface $message): SentMessage | |||
| 'apikey' => $this->apiKey, | |||
| 'message' => $message->getSubject(), | |||
| 'from' => $this->from, | |||
| 'test' => $this->testMode ? 0 : 1, | |||
| 'test' => !$this->testMode ? 0 : 1, | |||
There was a problem hiding this comment.
Suggested change
| 'test' => !$this->testMode ? 0 : 1, | |
| 'test' => $this->testMode ? 1 : 0, |
true/false mismatch for test_mode option
|
Could you please add test case to avoid further regressions? |
true/false mismatch for test_mode optiontrue/false mismatch for test_mode option
Added tests for test_mode |
stof
requested changes
Nov 21, 2022
src/Symfony/Component/Notifier/Bridge/SmsBiuras/Tests/SmsBiurasTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Nov 21, 2022
src/Symfony/Component/Notifier/Bridge/SmsBiuras/Tests/SmsBiurasTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/SmsBiuras/Tests/SmsBiurasTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Nov 21, 2022
stof
approved these changes
Nov 21, 2022
OskarStark
reviewed
Nov 21, 2022
src/Symfony/Component/Notifier/Bridge/SmsBiuras/Tests/SmsBiurasTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Nov 21, 2022
src/Symfony/Component/Notifier/Bridge/SmsBiuras/Tests/SmsBiurasTransportTest.php
Outdated
Show resolved
Hide resolved
|
And please make fabbot happy 😄 |
Fabbot happy too :D By the way, maybe I need to create for another branches changes to next up releases? |
true/false mismatch for test_mode optiontrue/false mismatch for test_mode option
|
No, we will handle the upmerge of your PR into newer branches 👌🏻 |
true/false mismatch for test_mode optiontrue/false mismatch for test_mode option
fabpot
approved these changes
Nov 22, 2022
|
Thank you @StaffNowa. |
OskarStark
pushed a commit
to OskarStark/symfony
that referenced
this pull request
Nov 22, 2022
…`test_mode` option (StaffNowa) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Notifier] [SMSBiuras] `true`/`false` mismatch for `test_mode` option | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Moved from LightSMS service into SMSBiuras and found an issue. SMSBIURAS_DSN=smsbiuras://UID:API_KEY@default?from=FROM&test_mode=0 Documentation is good but in the code bug. If test_mode = 0 - does not send SMS. If test_mode = 1 - sends SMS. Boolean true | false mismatch. SMSBiuras API documentation https://docs.smsbiuras.lt/ Commits ------- cd7e4d6 [Notifier] [SMSBiuras] `true`/`false` mismatch for `test_mode` option
OskarStark
added a commit
to OskarStark/symfony
that referenced
this pull request
Nov 22, 2022
OskarStark
added a commit
to OskarStark/symfony
that referenced
this pull request
Nov 22, 2022
OskarStark
added a commit
to OskarStark/symfony
that referenced
this pull request
Nov 22, 2022
fabpot
added a commit
that referenced
this pull request
Nov 23, 2022
…OskarStark) This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] [SmsBiuras] Simplify test and data provider | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT | Doc PR | Follows * #48262 Commits ------- 9221451 [Notifier][SmsBiuras] Simplify test and data provider
This was referenced Nov 25, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from LightSMS service into SMSBiuras and found an issue.
SMSBIURAS_DSN=smsbiuras://UID:API_KEY@default?from=FROM&test_mode=0
Documentation is good but in the code bug. If test_mode = 0 - does not send SMS. If test_mode = 1 - sends SMS.
Boolean true | false mismatch.
SMSBiuras API documentation https://docs.smsbiuras.lt/