Fix exception when convert Request to string #48327
Closed
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some application like https://github.com/shopware/platform , they will store some data in cookie by an array struct. It will throw an Exception when we try to log the request. This PR fix it.
|
Using arrays as cookie values does not look right to me. |
I agree with you, but some developer like to do it, and it is not forbid in symfony. You can see that profiler page can decode the array cookie correctly. |
|
This is indeed a “feature” of PHP:
@tourze bugfixes should also include test cases which would fail without them; could you do so in HttpFoundation’s |
purgenyo
approved these changes
Dec 7, 2022
|
Thank you for reporting and giving this PR a try. I submitted #48628 instead, which should be a bit more robust + is tested. Closing therefor. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2022
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] Fix dumping array cookies | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48327 | License | MIT | Doc PR | - See https://www.php.net/manual/en/function.setcookie.php#refsect1-function.setcookie-notes Commits ------- 3cf4401 [HttpFoundation] Fix dumping array cookies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some application like https://github.com/shopware/platform , they will store some data in cookie by an array struct. It will throw an Exception when we try to log the request. This PR fix it.