-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[TwigBridge] Amend MoneyType
twig to include a space
#48335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Failing on:
|
As this is a bugfix, it should probably not target the 6.3 branch |
They failing test looks like something with the ObjectNormalizer @dunglas. I won't even pretend to understand where the 'legacy nullable' type is. |
Argh, fecked that up. I'm checking out for tonight. My apologies to everyone. |
I haven't looked into the details of this ... but Bootstrap classes for money uses the So, the existing code ( |
The inner span is input-group-text. The outer div wrapper is class input-group. The issue is the outer div. |
MoneyType
twig to include a space
Mark, thanks for the additional insights! |
Thank you @mogilvie. |
Fix for MoneyType not rendering classes in Bootstrap 4&5.