[String] Fix AsciiSlugger with emojis #48395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4b97d7 to
37acb1b
Compare
nicolas-grekas
approved these changes
Nov 29, 2022
37acb1b to
2b046ee
Compare
lyrixx
reviewed
Nov 30, 2022
| $transliterator[] = EmojiTransliterator::create("emoji-{$this->emoji}"); | ||
| } elseif ($this->emoji && null !== $locale) { | ||
| $transliterator[] = EmojiTransliterator::create("emoji-{$locale}"); | ||
| if ($emojiTransliterator = $this->createEmojiTransliterator(\is_string($this->emoji) ? $this->emoji : ($this->emoji ? $locale : null))) { |
There was a problem hiding this comment.
I would pass the locale only to the fonction. And do some check there.
Ternary are harder to ready and I don't even talk about nested ternary 😁
|
Thank you @fancyweb. |
2b046ee to
5f320e5
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First fix: let's fall back to parent locales if the emoji map does not exist for the full locale? (like we do for symbols map)
Second fix: let's just ignore the emoji transliterator for totally unsupported locales, the behavior of the slugger will just strip the emojis like it already does.