[DependencyInjection] Fix bug when tag name is a text node #48449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
kniziol
reviewed
Dec 3, 2022
src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services10.xml
Show resolved
Hide resolved
|
Any news? |
kniziol
approved these changes
Dec 12, 2022
nicolas-grekas
approved these changes
Dec 13, 2022
|
Thank you @BrandonlinU. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in the ticket, I added a test for a tag without name attribute and content inside the tag for the name. I use
$tag->childElementCount !== 0instead of$tag->hasChildNode()to detect if a<attribute>tag is present in the tag definition, or is only the name of the tag.