[VarExporter] Fix possible memory-leak when using lazy-objects #48461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d918154 to
711afc4
Compare
711afc4 to
ce1ff9f
Compare
|
👍 I can confirm you fixed a memory leak. I had test on behat with symfony 6.1, with: 6.2 (tagged), i get 6.2.x-master on var-exporter component and I get Looks nice :) Thanks. |
Merged
fabpot
added a commit
that referenced
this pull request
Dec 9, 2022
…r references in the container (nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Use WeakReference to break circular references in the container | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - While working on #48461, I realized that we could break many circular loops involving the container by using a `WeakReference` to access it. This happens when we generate closures. Conceptually, we generate this at the moment: ```php $internalClosure = function () { return $this->get('foo'); }; ``` And we'd generate this with this PR: ```php $containerRef = \WeakReference::create($this); $internalClosure = static function () use ($containerRef) { return $containerRef->get()->get('foo'); }; ``` This should reduce the pressure on the garbage collector. Commits ------- a3b7fca [DependencyInjection] Use WeakReference to break circular references in the container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have loved to not store lazy-initializers in lazy objects, but this is not possible in PHP at the moment (see php/php-src#10043 for details).
This PR moves storing state of lazy objects inside the objects themselves. This fixes the memory leak by allowing the garbage collector to free memory as needed. This has the drawback of adding noise when
var_dump($lazyObject), but at least we can makedump($lazyObject)aware of that, thus the change on VarDumper.