Skip to content

[Notifier] Add Smsmode bridge #48496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

[Notifier] Add Smsmode bridge #48496

merged 1 commit into from
May 12, 2023

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#17511
Recipe symfony/recipes#1161

@gnito-org gnito-org requested a review from OskarStark as a code owner December 5, 2022 18:58
@carsonbot carsonbot added this to the 6.3 milestone Dec 5, 2022
OskarStark
OskarStark reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and please make fabbot happy, thanks

@OskarStark
Copy link
Contributor

Logos good after my comments.

Again thank you for your patience @gnito-org 👍

@nicolas-grekas
Copy link
Member

Thank you @gnito-org.

@nicolas-grekas nicolas-grekas merged commit 725fac4 into symfony:6.3 May 12, 2023
@fabpot fabpot mentioned this pull request May 13, 2023
Merged
@gnito-org gnito-org deleted the smsmode-bridge branch May 31, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@gnito-org @OskarStark @nicolas-grekas @carsonbot