[Notifier] Add symfony/event-dispatcher to bridges' require-dev section
#48548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 (not sure)". Cheers! Carsonbot |
51243ff to
2d42a02
Compare
…ection Also increase some php requirements to `>=8.1` and remove `ext-json` from `require` section as its always available since PHP 8 Not sure if this is the right branch
2d42a02 to
0424c41
Compare
|
Why? Tests pass without this change, right? |
|
Maybe because |
|
So how do we proceed here? |
|
Adding event-dispatcher is not needed since it's not used in tests. I've applied the other changes you spotted from 5.4 to 6.3, see ad3424c for the last merge up. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/event-dispatcheris used in all tests.Also increase some php requirements to
>=8.1Not sure if this is the right branch