[Notifier] Add SMS options to MessageMedia notifier #48586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnito-org
commented
Dec 9, 2022
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR | N/A |
|
Hey! I think @alamirault has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
| $this->options = $options; | ||
| } | ||
|
|
||
| public function getCallbackUrl(): ?string |
There was a problem hiding this comment.
Can't we remove all getters? I don't think it's worth exposing them. toArray() works fine for the purpose.
Can you consider this for all your PRs please?
There was a problem hiding this comment.
Removing all the getters is inconsistent with the MessageOptionsInterface.
|
Thank you @gnito-org. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.