Skip to content

[HttpKernel] fix wrong deprecation message #48608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

soyuka
Copy link
Contributor

@soyuka soyuka commented Dec 12, 2022

Q A
Branch? 6.3
Bug fix? yes
New feature? no
License MIT

Introduced in #47680

Not sure about how to catch the deprecation.

@chalasr
Copy link
Member

chalasr commented Dec 12, 2022

Not sure about how to catch the deprecation.

Can you elaborate?

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the tests was that expectations were defined after the call that triggered them.

@nicolas-grekas nicolas-grekas force-pushed the fix/wrong-kernel-deprecation branch from 19eb582 to 6bfc18d Compare December 13, 2022 08:37
@nicolas-grekas
Copy link
Member

Thank you @soyuka.

@nicolas-grekas nicolas-grekas merged commit 4829c67 into symfony:6.3 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants