[HttpFoundation] Use relative timestamps with MemcachedSessionHandler #48635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Dec 13, 2022
| @@ -77,7 +77,7 @@ protected function doRead(string $sessionId) | |||
| #[\ReturnTypeWillChange] | |||
| public function updateTimestamp($sessionId, $data) | |||
| { | |||
| $this->memcached->touch($this->prefix.$sessionId, time() + (int) ($this->ttl ?? \ini_get('session.gc_maxlifetime'))); | |||
There was a problem hiding this comment.
I've read up how PHP's memcached extension interprets the values passed here: https://www.php.net/manual/en/memcached.expiration.php
tl;dr: If the passed integer is < 30 days in seconds, the value is considered to be a relative TTL. Otherwise, the value is assumed to be a UNIX timestamp.
My guess is that we added time() to be sure our relative TTL is never mistaken as a timestamp.
If we go back to relative TTLs again, I suggest we make sure our TTL is below that threshold and continue to add time() otherwise.
There was a problem hiding this comment.
7568a82 to
3e65ba6
Compare
3e65ba6 to
cb2178d
Compare
|
Thank you @tvlooy. |
Merged
This was referenced Dec 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use relative timestamps. If for some reason your client is not in sync with the server clock, you at least agree about the relative TTL. Or see #48619 for a case where the memcached monotonic clock is going faster than the server and causes users to add entries that are expired on entry.