[PropertyAccess] Fix nullsafe chain like x?.y #48727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomLorenzi
reviewed
Dec 21, 2022
src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Dec 22, 2022
|
Thank you @Vincz. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 23, 2022
This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [PropertyAccess] Fix nullsafe chain like x?.y | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48726 | License | MIT Fix objects reading with path like `x?.y` so reading should stop and return `null` if the property `x` is null. Currently, the system tries to read the property `y` from the `null` value and raises an exception. Commits ------- 92db003 [PropertyAccess] Fix nullsafe chain like x?.y
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix objects reading with path like
x?.yso reading should stop and returnnullif the propertyxis null.Currently, the system tries to read the property
yfrom thenullvalue and raises an exception.