[String] Add support for kebab case #48781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 28, 2022
| @@ -214,6 +214,14 @@ public function join(array $strings, string $lastGlue = null): static | |||
| return $str; | |||
| } | |||
|
|
|||
| public function kebab(): static | |||
| { | |||
| $str = $this->camel(); | |||
There was a problem hiding this comment.
camel()->lower()->replace('_', '-')
Is not enough? Just asking
There was a problem hiding this comment.
If that's the case, maybe we don't need yet another method?
There was a problem hiding this comment.
The snake() function uses the same process:
https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/String/AbstractUnicodeString.php#L349
There was a problem hiding this comment.
camel()->lower()->replace('_', '-')
Is not enough? Just asking
Your example does not work.
There was a problem hiding this comment.
Right, it's snake()->replace('_', '-'), I think.
derrabus
requested changes
Dec 28, 2022
| @@ -390,6 +390,8 @@ public function jsonSerialize(): string | |||
| return $this->string; | |||
| } | |||
|
|
|||
| abstract public function kebab(): static; | |||
There was a problem hiding this comment.
AbstractString is not @internal, so this is a BC-break, I believe.
fabpot
added a commit
that referenced
this pull request
Sep 30, 2024
…xandre-daubois) This PR was merged into the 7.2 branch. Discussion ---------- [String] Add the `AbstractString::kebab()` method | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #48780 | License | MIT Supersedes #48781. It seems there's quite a demand for this feature. I think it is a nice DX improvement which also helps readability over calling `snake()->replace('_', '-')`. Commits ------- b2b82d6 [String] Add the `AbstractString::kebab()` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add suport for kebab case for String Component.