Skip to content

[Console] Correctly overwrite progressbars with different line count per step #48784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

[Console] Correctly overwrite progressbars with different line count per step #48784

merged 1 commit into from
Dec 28, 2022

Conversation

ncharalampidis
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

When ProgressBar is used with multi-line format and in every step the line count is not the same, then overwriting is not working properly.

Code to reproduce:

$progress = new ProgressBar;

$progress->setFormatDefinition(
    'custom',
    " %current%/%max% [%bar%] %percent:3s%% %memory:6s%\n%debug%"
);

$progress->setFormat('custom');

$progress->setPlaceholderFormatterDefinition('debug', function () {
    return str_repeat("\n...", $progress->getProgress());
});

@carsonbot carsonbot added this to the 5.4 milestone Dec 24, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Correctly overwrite progressbars with different line count per step [Console] Correctly overwrite progressbars with different line count per step Dec 28, 2022
@nicolas-grekas
Copy link
Member

Thank you @ncharalampidis.

@nicolas-grekas nicolas-grekas merged commit 5dcb529 into symfony:5.4 Dec 28, 2022
This was referenced Dec 28, 2022
Merged
Merged
Merged
Merged
@ncharalampidis ncharalampidis deleted the 5.4 branch December 29, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ncharalampidis @carsonbot @nicolas-grekas