Skip to content

[DependencyInjection] Fix deduplicating service instances in circular graphs #48791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

[DependencyInjection] Fix deduplicating service instances in circular graphs #48791

merged 1 commit into from
Dec 28, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted while inspecting a non trivial service graph.

We're missing a few isset checks to dedup services created when circular refs involve lazy services.

@carsonbot carsonbot added this to the 5.4 milestone Dec 26, 2022
@nicolas-grekas nicolas-grekas force-pushed the di-fix branch 2 times, most recently from 5c13379 to 528ff30 Compare December 27, 2022 09:00
@nicolas-grekas nicolas-grekas merged commit 2a2b72c into symfony:5.4 Dec 28, 2022
@nicolas-grekas nicolas-grekas deleted the di-fix branch December 28, 2022 14:39
This was referenced Dec 28, 2022
Merged
Merged
Merged
Merged
@adamwojs adamwojs mentioned this pull request Dec 28, 2022
Merged
4 tasks
This was referenced Jan 5, 2023
Closed
Closed
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Jan 12, 2023
@nicolas-grekas
[DependencyInjection] Revert "bug symfony#48791 Fix deduplicating ser…
81ae78a 
…vice instances in circular graphs"

This reverts commit 2a2b72c, reversing
changes made to e7ec8a6.
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Jan 12, 2023
@nicolas-grekas
[DependencyInjection] Revert "bug symfony#48791 Fix deduplicating ser…
6a4ba0e 
…vice instances in circular graphs"

This reverts commit 2a2b72c, reversing
changes made to e7ec8a6.
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 12, 2023
Closed
@spantaleev spantaleev mentioned this pull request Jan 18, 2023
Closed
@julienfalque julienfalque mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot