Skip to content

Leverage arrow function syntax for closure #48793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

tigitz
Copy link
Contributor

@tigitz tigitz commented Dec 26, 2022

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #47658
License MIT
Doc PR

Rationale in the RFC here

It's also notable that using arrow function syntax rather than the classic one has been enforced in the past by symfony core member: #48069 (comment)

So this PR would be consistent.

@tigitz tigitz force-pushed the arrow-functions branch 2 times, most recently from 1642ba2 to a3ba4fe Compare January 1, 2023 18:45
@nicolas-grekas nicolas-grekas force-pushed the arrow-functions branch 2 times, most recently from 0e5f4d8 to d08a503 Compare January 13, 2023 09:13
@nicolas-grekas
Copy link
Member

Thank you @tigitz.

@nicolas-grekas nicolas-grekas merged commit acb7a98 into symfony:6.3 Jan 13, 2023
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
This PR was merged into the 6.3 branch.

Discussion
----------

Leverage arrow function syntax for closure

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix symfony#47658 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | <!-- required for new features -->

Rationale in the RFC [here](https://wiki.php.net/rfc/arrow_functions_v2#introduction)

It's also notable that using arrow function syntax rather than the classic one has been enforced in the past by symfony core member: symfony#48069 (comment)

So this PR would be consistent.

Commits
-------

f5802d3 Leverage arrow function syntax for closure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize current code base with the help of automated tools (e.g. rector)
4 participants