Drop v1 contracts packages everywhere #48810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ | |||
| "php": ">=8.1", | |||
| "friendsofphp/proxy-manager-lts": "^1.0.2", | |||
| "symfony/dependency-injection": "^6.3", | |||
| "symfony/deprecation-contracts": "^2.1|^3" | |||
| "symfony/deprecation-contracts": "^2.5|^3" | |||
There was a problem hiding this comment.
why bump deprecation-contracts? better not if not needed don't you think?
There was a problem hiding this comment.
For consistency, mainly. 2.5 is the release we still maintain in our LTS branch. Do you want to define a different target 2.x minor version for each contracts package? If so, let's define them and I adjust the PR.
There was a problem hiding this comment.
OK.
I looked for bumping to v3 but that'd make our packages less compatible with third party packages.
nicolas-grekas
approved these changes
Dec 28, 2022
OskarStark
approved these changes
Dec 28, 2022
chalasr
approved these changes
Dec 28, 2022
yceruto
approved these changes
Dec 28, 2022
|
Thank you @derrabus. |
This was referenced Jan 5, 2023
fabpot
added a commit
that referenced
this pull request
Jan 7, 2023
…ibute (alexislefebvre) This PR was merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] remove double required annotation + attribute | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48792 (checked with [this reproducer](#48792 (comment))) | License | MIT | Doc PR | no Annotation and attribute were kept: #45680 (comment) To my understanding, it's not necessary since #48810 Alternative to #48868 Commits ------- 8e8772d remove double required annotation + attribute
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1 of the Symfony contracts have been released during the Symfony 4.x days, but still many Symfony 6 components declare compatibility with them:
symfony/src/Symfony/Component/DependencyInjection/composer.json
Line 22 in a8bbf63
This circumstance complicates our build matrix and makes issues like #48792 hard to track down.
Version 2 was released together with Symfony 5 which means that we really only need v1 contracts if we want to actively support Symfony 4 components which are EOL and already unsupported by Symfony 6. I make the bold assumption that no Symfony 6 app should be required to pin any of the contracts packages to v1 or even an outdated v2 minor release.
This is why I propose to drop support for contracts v1 everywhere it did not happen already, making
^2.5 || ^3the loosest constraint we use for a contracts package on a Symfony 6.3 component or bundle.