-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Cache] Fix for RedisAdapter without auth parameter #48816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
I checked the errors from fabbot, but it seems to change switch-case constructions elsewhere in the file. Although being perhaps better according PSR, not intending on more changes than neccecairy. |
Your changes works for me symfony v.6.2.3 |
A test case would be useful. |
@chalasr I thought about it. But I didn't know where to start without all kinds of complicated Redis spin-up stuff. But to prevent regression in the future it would be useful. It would probably require mocking a lot of stuff. |
There's already a test case as this fixes our integration tests. |
Thanks @rikvdh. |
Compatibility with Redis without auth was broken by #48711, this change fixes this.
This applies for all versions (6.x as well).