Skip to content

[Translation] Fix for resolving Constraint Validator FQCN defined as %foo.bar.class% parameters #48846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

[Translation] Fix for resolving Constraint Validator FQCN defined as %foo.bar.class% parameters #48846

merged 1 commit into from
Jan 5, 2023

Conversation

gassan
Copy link
Contributor

@gassan gassan commented Jan 1, 2023 •
edited
Loading

For example Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntityValidator is defined as %doctrine.orm.validator.unique.class% and must be properly resolved.

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
License MIT

@carsonbot carsonbot added this to the 6.3 milestone Jan 1, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@gassan gassan changed the base branch from 6.3 to 6.2 January 1, 2023 13:39
@gassan gassan force-pushed the resolve-validator-class-given-as-parameter branch from 1de47b6 to 991aed9 Compare January 1, 2023 13:53
@gassan gassan changed the title [Translation] Fix for resolving validator class names defined as %foo.bar.class% parameters [Translation] Fix for resolving Constraint Validator FQCN defined as %foo.bar.class% parameters Jan 1, 2023
derrabus
derrabus requested changes Jan 1, 2023
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that covers your change.

@derrabus derrabus modified the milestones: 6.3, 6.2 Jan 1, 2023
@derrabus
Copy link
Member

derrabus commented Jan 1, 2023

Is this bug present in Symfony 6.2 only or is 5.4 affected as well?

@gassan gassan force-pushed the resolve-validator-class-given-as-parameter branch from 991aed9 to 802ed1e Compare January 1, 2023 20:59
@gassan gassan force-pushed the resolve-validator-class-given-as-parameter branch from 802ed1e to c965b03 Compare January 1, 2023 21:35
@gassan
Copy link
Contributor Author

gassan commented Jan 1, 2023

Is this bug present in Symfony 6.2 only or is 5.4 affected as well?

I think it is an S6.2 enhancement for extracting /.*message/i from Entity Attributes.

@derrabus
Copy link
Member

derrabus commented Jan 1, 2023

Right, this piece of code has been introduced with #46161.

@derrabus derrabus requested a review from welcoMattic January 1, 2023 21:48
@fabpot
Copy link
Member

fabpot commented Jan 5, 2023

Thank you @gassan.

@fabpot fabpot merged commit 20851ea into symfony:6.2 Jan 5, 2023
@gassan gassan deleted the resolve-validator-class-given-as-parameter branch January 5, 2023 09:28
@fabpot fabpot mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

Assignees
No one assigned
Labels
Bug Status: Reviewed Translation
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@gassan @carsonbot @derrabus @fabpot @xabbuh