Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "5.4 and above".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Hey!

I think @yoannrenard has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Can you add a test case to avoid regressions?

Can you add a test case to avoid regressions?

I don't have much time, but I'll try to add a test for it.

Thank you @cay89.