[Console] fix clear of section with question #48897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problems to clear a section with a question included.
Example Code:
Output loop 1:

Output loop 1:

There was already a fix #48089 to be merged in 6.1, but the problem was that there were some changes in 6.2, so it was not possible to merge it into 6.2.
So this fix is only working for 6.2, but perhaps we could find a solution as well for the older versions. But because of the changes of console it was not possible to find a solution working for all versions.
@chalasr this fix is still with the newline always
true
symfony/src/Symfony/Component/Console/Output/ConsoleSectionOutput.php
Line 181 in 4cf9855
A change of the newline to
$newline
would change the behavior. Maybe we could change that in symfony 7.To make it easier to test is here a zip with 2 testcommands in the root and the changed vendors.
test-48089.zip