Allow Usage of ContentId in html #48901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
bf83dce to
d0402c3
Compare
nicolas-grekas
approved these changes
Jan 9, 2023
Detect usage of Content-Id in html and mark part as related, just as it would happen with a `cid:<name>` reference.
d0402c3 to
a5e4fc2
Compare
nicolas-grekas
approved these changes
Jan 9, 2023
fabpot
approved these changes
Jan 9, 2023
|
Thank you @m42e. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect usage of Content-Id in html and mark part as related, just as it would happen with a
cid:<name>reference.Assumed you have a defined
Content-Idfor your attachment, as you modify and forward an id.The HTML part will already contain the reference to that id in the
cid:reference. Which means the name is no longer part of the html body. In this case it is currently not detected that the parts are related to each other.This will be improved with this PR.
I do not consider it a bug fix. The feature has a very special use case. If you consider otherwise, let me know and I will create a PR against the maintenance branch. (I already have one prepared: https://github.com/m42e/symfony/tree/allow-usage-of-content-id-in-html-5.4 Which means the feature/fix would reach more people. Please let me know what you think.)