Skip to content

[VarExporter] Fix signature of Lazy*Trait::createLazy*() #48939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 10, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix doctrine/DoctrineBundle#1615
License MIT
Doc PR -

Using self makes the traits incompatible with inheritance as child classes cannot also use the trait when a parent class already does.

@carsonbot carsonbot added this to the 6.2 milestone Jan 10, 2023
@nicolas-grekas nicolas-grekas changed the title [Intl] Get emoji-test.txt from unicode.org [VarExporter] Fix signature of Lazy*Trait::createLazy*() Jan 10, 2023
@symfony symfony deleted a comment from carsonbot Jan 10, 2023
@carsonbot carsonbot changed the title [VarExporter] Fix signature of Lazy*Trait::createLazy*() [Intl] Fix signature of Lazy*Trait::createLazy*() Jan 10, 2023
@stof stof added VarExporter and removed Intl labels Jan 10, 2023
@carsonbot carsonbot changed the title [Intl] Fix signature of Lazy*Trait::createLazy*() [VarExporter] Fix signature of Lazy*Trait::createLazy*() Jan 10, 2023
@fabpot
Copy link
Member

fabpot commented Jan 10, 2023

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f05cc8d into symfony:6.2 Jan 10, 2023
@nicolas-grekas nicolas-grekas deleted the ve-lazy-static branch January 11, 2023 13:27
@fabpot fabpot mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants