Remove full DSNs from exception messages #49072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
reviewed
Jan 23, 2023
8258695 to
8afc181
Compare
|
/cc @NicolasCARPi also FYI since we discussed about that privately. |
8afc181 to
1cbd95e
Compare
|
Thanks everyone 👍 :) |
| } | ||
|
|
||
| if ($params['redis_cluster'] && isset($params['redis_sentinel'])) { | ||
| throw new InvalidArgumentException(sprintf('Cannot use both "redis_cluster" and "redis_sentinel" at the same time: "%s".', $dsn)); | ||
| throw new InvalidArgumentException('Cannot use both "redis_cluster" and "redis_sentinel" at the same time.'); |
There was a problem hiding this comment.
: has been changed to ., it looks like it breaks some tests: https://github.com/symfony/symfony/actions/runs/3988999209/jobs/6840883282#step:11:78
There was a problem hiding this comment.
Let's fix this in GH-49080
|
I agree |
fabpot
added a commit
that referenced
this pull request
Nov 3, 2023
This PR was merged into the 5.4 branch. Discussion ---------- Remove full DSNs from exception messages | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Backporting #49072 to 5.4 as a security-hardening measure. Commits ------- 14e2f67 Remove full DSNs from exception messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #49065
We should be careful when reviewing notifier bridges, to ensure that transports'
__toString()don't embed any secrets. /cc @OskarStark