[DoctrineBridge] fix issue with missing stopwatch events #49079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
65788a3 to
56c9f92
Compare
src/Symfony/Bridge/Doctrine/Tests/Middleware/Debug/MiddlewareTest.php
Outdated
Show resolved
Hide resolved
|
@stof maybe you have some time to review this? |
maxhelias
approved these changes
Feb 15, 2023
56c9f92 to
f69dd0f
Compare
fabpot
approved these changes
Apr 5, 2023
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Apr 5, 2023
…dmaicher) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] fix issue with missing stopwatch events | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix doctrine/DoctrineBundle#1622 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> This fixes doctrine/DoctrineBundle#1622 We were not triggering the stopwatch events/sections properly when using prepared statements. Now it works:   Commits ------- 52f4f7b [DoctrineBridge] fix issue with missing stopwatch events
f69dd0f to
52f4f7b
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes doctrine/DoctrineBundle#1622
We were not triggering the stopwatch events/sections properly when using prepared statements.
Now it works: