[Security/Http] Fix compat of persistent remember-me with legacy tokens #49103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jan 25, 2023
| @@ -45,7 +44,6 @@ public function __construct(TokenProviderInterface $tokenProvider, string $secre | |||
| } | |||
| $this->tokenProvider = $tokenProvider; | |||
| $this->tokenVerifier = $tokenVerifier; | |||
| $this->secret = $secret; | |||
There was a problem hiding this comment.
unused property after #49078
There was a problem hiding this comment.
should we deprecate the constructor argument ?
There was a problem hiding this comment.
we could but not in 5.4
stof
approved these changes
Jan 25, 2023
chalasr
approved these changes
Jan 25, 2023
|
We can keep that logic forever, we don't really care IMHO. |
|
Hi @nicolas-grekas, Thanks for the quick fix. "repositories": [
{
"_comment": "Testing: https://github.com/symfony/symfony/pull/49103",
"type": "git",
"url": "https://github.com/nicolas-grekas/symfony.git"
}
]Doing this command does not work: It looks like composer is ignoring your repo and I have no idea why. Thanks! |
This was referenced Feb 1, 2023
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Apr 8, 2023
…stentRememberMeHandler constructor (xabbuh) This PR was merged into the 6.3 branch. Discussion ---------- [Security] deprecate the $secret argument of the PersistentRememberMeHandler constructor | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | #49103 (comment) | License | MIT | Doc PR | Commits ------- bf81d66 deprecate the $secret argument of the PersistentRememberMeHandler constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #49078, we changed the format of remember-me tokens, effectively invalidating them all.
While the invalidation is intentional for signature-based remember-me handlers, persistent remember-me handlers could accept both legacy and updated tokens.
This PR fixes compat with legacy tokens for persistent remember-me handlers.