[FrameworkBundle] Detect unused environment variables in .env #49161
+68
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Jan 30, 2023
There was a problem hiding this comment.
I like this way of demonstrating usage of each variable.
Here is the output for symfony/demo. We can see that APP_ENV is not used by the container (because it is used earlier).
$ bin/console debug:container --env-vars
Symfony Container Environment Variables
=======================================
------------------- ------------------ ------------------------------------------------------- -------------
Name Default value Real value Usage count
------------------- ------------------ ------------------------------------------------------- -------------
APP_ENV n/a "dev" 0
APP_SECRET n/a "2ca64f8d83b9e89f5f19d672841d6bb8" 8
DATABASE_URL n/a "sqlite:///%kernel.project_dir%/data/database.sqlite" 1
VAR_DUMPER_SERVER "127.0.0.1:9912" n/a 3
------------------- ------------------ ------------------------------------------------------- -------------
// Note real values might be different between web and CLI.
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
Outdated
Show resolved
Hide resolved
|
@GromNaN Thanks for the suggestions, I made changes in the code. |
GromNaN
requested changes
Feb 2, 2023
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/Descriptor.php
Outdated
Show resolved
Hide resolved
GromNaN
requested changes
Feb 2, 2023
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ContainerDebugCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ContainerDebugCommandTest.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved
bin/console debug:container --env-varsand the--env-varoption to display the number of occurrences of each environment variable in the container. This allows you to identify unused variables from .env files.Example usage:
php bin/console debug:container --env-varsphp bin/console debug:container --env-var=APP_SECRET