[Ldap] Allow multiple values on extra_fields
#49187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
765d893 to
e51b502
Compare
OskarStark
approved these changes
Feb 1, 2023
|
One could argue, that this is a new feature, but I am for handling this as a bugfix and merge it in |
nicolas-grekas
approved these changes
Feb 1, 2023
|
Thank you @mvhirsch. |
|
This "fix" breaks BC in my case. Had to update all occurences. An upgrade notice would be very nice for that. That happens for all extraFields that are not "uidKey" or "passwordAttribute". |
|
I think a BC break as not planned here. Not sure how to fix this. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 13, 2024
…ds()` (mvhirsch) This PR was merged into the 5.4 branch. Discussion ---------- [Ldap] Adds return value hint of `LdapUser::getExtraFields()` Hi, I'm not sure if this is the correct approach to document that. Please advice me where to document this. I'd love to get this done correctly. - Fixes symfony/symfony#49994 - refs symfony/symfony#49187 Commits ------- f75e437 adds hint of return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading users with the
LdapUserProvider, usingextra_fieldsfails if I want to getmemberOfattribute.This happens, if my user has multiple attributes set. After taking a look at
Ldap\Entry(which supports multiple values per attribute). Looking atLdapUserProvider::getAttributeValue()it was very clear, that every attribute must be unique.The method
getAttributeValue()has originated fromgetPassworddbf45e4, forcing the password attribute to be unique. Same goes foruidKeyc91689b. Loadingextra_fieldsshould allow for multiple values per attribute (likememberOf).Did I break backward compatibility? No, I didn't. Simply because it was never usable as array while loading users via
LdapUserProvider, instead anInvalidArgumentExceptionwas thrown.