[Form] Fix PasswordHasherListener to work with empty data
#49208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
791d794 to
6494370
Compare
PasswordHasherListener to work with empty data
yceruto
approved these changes
Feb 3, 2023
stof
approved these changes
Feb 3, 2023
fabpot
approved these changes
Feb 4, 2023
|
Thank you @1ed. |
| @@ -77,6 +77,42 @@ public function testPasswordHashSuccess() | |||
| $this->assertSame($user->getPassword(), $hashedPassword); | |||
| } | |||
|
|
|||
| public function testPasswordHashSuccessWitnEmptyData() | |||
There was a problem hiding this comment.
testPasswordHashSuccessWitnEmptyData
should be:
testPasswordHashSuccessWithEmptyData
There was a problem hiding this comment.
good catch, but it's already fixed in the 6.2 branch :) (see d88d5b3)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case when a new user is created by the form,
for example in a registration form. Before this the listener
thrown an exception, because when it tried to get the user
it was not available yet. With this the user resolved later
at the root form when empty data already ran. Other then that
the logic is the same just refactored a code a bit to make it
more readable.